Don't require sqlite3 when using postgres

[anoadragon453]

There's no need to import and use sqlite3 if you're using postgres as your db backend.

[codecov-io]

Codecov Report

Merging #4466 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #4466      +/-   ##
===========================================
+ Coverage     74.7%   74.72%   +0.01%     
===========================================
  Files          336      336              
  Lines        35041    34056     -985     
  Branches      5875     5538     -337     
===========================================
- Hits         26179    25448     -731     
+ Misses        7237     7036     -201     
+ Partials      1625     1572      -53

Impacted Files	Coverage Δ
synapse/storage/engines/sqlite.py	100% <100%> (ø)	⬆️
synapse/util/frozenutils.py	23.33% <0%> (-30%)	⬇️
synapse/handlers/search.py	74.01% <0%> (-6.24%)	⬇️
synapse/events/__init__.py	87.82% <0%> (-5.3%)	⬇️
synapse/federation/federation_client.py	71.95% <0%> (-3.68%)	⬇️
synapse/handlers/federation.py	61.43% <0%> (-2.91%)	⬇️
synapse/api/filtering.py	95.42% <0%> (-1.9%)	⬇️
synapse/storage/state.py	84.9% <0%> (-1.67%)	⬇️
synapse/handlers/user_directory.py	71.25% <0%> (-0.3%)	⬇️
synapse/federation/federation_base.py	68.62% <0%> (ø)	⬆️
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50c396a...427b093. Read the comment docs.

[richvdh]

lgtm apart from the changelog

[anoadragon453]

Ah, good to know, thanks!

…

On January 24, 2019 5:43:22 PM UTC, Richard van der Hoff ***@***.***> wrote: richvdh requested changes on this pull request. lgtm apart from the changelog > @@ -0,0 +1 @@ +Don't require sqlite3 when using postgres as the database backend. this isn't a change since the last release, so doesn't make sense to list in the changelog. (If it *was* a change since the last release, it would be a bugfix, not a misc.) It would make more sense to consider it as part of the PR which introduced the breakage (#4306, it turns out). So copy 4306.misc to 4466.misc, and the two will share a line when towncrier builds the changelog. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #4466 (review)