Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fixup generated metrics config #4694

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented Feb 20, 2019

Now looks like:

## Metrics ###

# Enable collection and rendering of performance metrics
enable_metrics: False

# Enable sentry integration
# NOTE: While attempts are made to ensure that the logs don't contain
# any sensitive information, this cannot be guaranteed. By enabling
# this option the sentry server may therefore receive sensitive
# information, and it in turn may then diseminate sensitive information
# through insecure notification channels if so configured.
#sentry:
#    dsn: "..."

# Whether or not to report anonymized homeserver usage statistics.
report_stats: true

Broke by #4632

@erikjohnston erikjohnston requested a review from a team February 20, 2019 13:40
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-io
Copy link

Codecov Report

Merging #4694 into develop will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #4694      +/-   ##
===========================================
+ Coverage    75.13%   75.16%   +0.03%     
===========================================
  Files          340      340              
  Lines        34811    34811              
  Branches      5701     5701              
===========================================
+ Hits         26155    26166      +11     
+ Misses        7046     7036      -10     
+ Partials      1610     1609       -1

@erikjohnston erikjohnston merged commit 82fca11 into develop Feb 20, 2019
@erikjohnston erikjohnston deleted the erikj/fix_sentry_config_format branch March 5, 2019 13:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants