This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Stop backpaginating when events not visible #4699
Merged
+127
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #4699 +/- ##
==========================================
- Coverage 75.09% 74.4% -0.69%
==========================================
Files 340 340
Lines 34923 35795 +872
Branches 5723 5982 +259
==========================================
+ Hits 26225 26635 +410
- Misses 7088 7518 +430
- Partials 1610 1642 +32 |
richvdh
reviewed
Feb 21, 2019
richvdh
previously requested changes
Feb 27, 2019
erikjohnston
force-pushed
the
erikj/stop_fed_not_in_room
branch
from
8da569d to
7356052
Compare
When filtering events to send to server we check more than just history visibility. However when deciding whether to backfill or not we only care about the history visibility.
erikjohnston
force-pushed
the
erikj/stop_fed_not_in_room
branch
from
7356052 to
d1523ae
Compare
richvdh
approved these changes
Mar 4, 2019
| # TODO: If we do do a backfill the we should filter the extremities to | ||
| # only include those that point to visible portions of history. | ||
| # | ||
| # TODO: Correctly handle the case where we are allowed to see the |
There was a problem hiding this comment.
how would we do this? is it a thing we are ever likely to be able to do? if not, a TODO is inappropriate
There was a problem hiding this comment.
It should be possible, I've updated the comment with roughly what's needed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.