This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add prometheus metrics for number of badge update pushes. #4709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're counting the number of push notifications, but not the number of badges; I'd like to see if they are significant.
| defer.returnValue(False) | ||
| rejected = [] | ||
| if 'rejected' in resp: | ||
| rejected = resp['rejected'] |
There was a problem hiding this comment.
well, maybe, but we don't use it.
Codecov Report
@@ Coverage Diff @@
## develop #4709 +/- ##
===========================================
+ Coverage 74.98% 75.16% +0.17%
===========================================
Files 340 340
Lines 34814 34815 +1
Branches 5702 5702
===========================================
+ Hits 26107 26168 +61
+ Misses 7085 7036 -49
+ Partials 1622 1611 -11 |
erikjohnston
approved these changes
Feb 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're counting the number of push notifications, but not the number of badges;
I'd like to see if they are significant.