Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Use correct config option for ratelimiting in tests #5185

Merged
merged 2 commits into from
May 15, 2019

Conversation

erikjohnston
Copy link
Member

@erikjohnston erikjohnston commented May 14, 2019

This doesn't actually break any unit tests currently (surprisingly), but does break unit tests on my branch.

Broke in #5171

@erikjohnston erikjohnston requested a review from a team May 14, 2019 13:39
@codecov
Copy link

codecov bot commented May 14, 2019

Codecov Report

Merging #5185 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #5185   +/-   ##
========================================
  Coverage    62.15%   62.15%           
========================================
  Files          336      336           
  Lines        34659    34659           
  Branches      5694     5694           
========================================
  Hits         21541    21541           
  Misses       11583    11583           
  Partials      1535     1535

@erikjohnston
Copy link
Member Author

This is probably also fixed by #5181

Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@erikjohnston erikjohnston merged commit 99c7dae into develop May 15, 2019
@erikjohnston erikjohnston deleted the erikj/fix_config_ratelimiting branch January 9, 2020 15:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants