Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

scripts-dev/check_event_hash.py doesn't work anymore #5289

Closed
turt2live opened this issue May 29, 2019 · 3 comments
Closed

scripts-dev/check_event_hash.py doesn't work anymore #5289

turt2live opened this issue May 29, 2019 · 3 comments
Assignees
@hawkowl
Labels
z-bug (Deprecated Label) z-p3 (Deprecated Label)

Comments

@turt2live
Copy link
Member

It complains about missing a format_version on the event. See #5281 for a not-too-great fix.
@turt2live turt2live mentioned this issue May 29, 2019
Closed
@richvdh
Copy link
Member

richvdh commented May 30, 2019

Honestly, I'd be more inclined to get rid of it than fix it. I don't really know what it's supposed to do (it doesn't have a single comment), and it's clearly been forgotten. Is it actually fulfilling a useful purpose?

@turt2live
Copy link
Member Author

It was useful to check a hash, but admittedly I've only ever used it twice. Being a dev script, I'd support removing it as it's a clear dust collector

@neilisfragile neilisfragile added z-bug (Deprecated Label) z-p3 (Deprecated Label) labels Jun 7, 2019
@hawkowl hawkowl self-assigned this Jun 25, 2019
@hawkowl hawkowl mentioned this issue Jun 25, 2019
Merged
@richvdh
Copy link
Member

richvdh commented Jun 25, 2019

removed in #5548

@richvdh richvdh closed this as completed Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hawkowl hawkowl

Labels
z-bug (Deprecated Label) z-p3 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@neilisfragile @turt2live @richvdh @hawkowl