Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Room Stats: state_events and current_state_events are never updated following the initial background update. #5690

Closed
reivilibre opened this issue Jul 16, 2019 · 4 comments
Assignees
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@reivilibre
Copy link
Contributor

reivilibre commented Jul 16, 2019

Clarification: state_events & current_state_events refer to the columns in room_stats

state_events should be relatively trivial to update. is going to be dumped.

current_state_events may be slightly trickier – ah, but I guess I can increment if the state event doesn't have a previous event – maybe not trickier after all.

@reivilibre reivilibre self-assigned this Jul 16, 2019
@richvdh
Copy link
Member

richvdh commented Jul 16, 2019

is this not the same as #5624?

@reivilibre
Copy link
Contributor Author

reivilibre commented Jul 18, 2019

is this not the same as #5624?

No, #5624 concerns rooms missing stats altogether (no rows) and affects new rooms.

This concerns the fact that stats will not be incrementally updated properly for rooms which are properly registered in the room stats system ({current_,}state_events not updated to reflect actual value). All rooms are affected.

@reivilibre
Copy link
Contributor Author

Note that it has been decided to dump state_events as it is not a statistic with known uses right now – and it is slightly troublesome to track. So this issue now focusses on current_state_events and will drop state_events.

@erikjohnston
Copy link
Member

Fixed in #5971

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

4 participants