Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Soft logout: /logout should not return 401 (soft_logout) #5756

Closed
manuroe opened this issue Jul 24, 2019 · 3 comments
Closed

Soft logout: /logout should not return 401 (soft_logout) #5756

manuroe opened this issue Jul 24, 2019 · 3 comments
Assignees

Comments

@manuroe
Copy link
Contributor

manuroe commented Jul 24, 2019

The /logout endpoint should instead succeed so that the used device_id can be trashed.

Currently, the user keeps a zombie device id after each soft logout.

@anoadragon453
Copy link
Member

anoadragon453 commented Apr 16, 2020

So if I understand this correctly, when you receive a 401; {soft_logout: true} in a response, you try to /logout and get a 401 from that endpoint as well instead of a 200?

Edit: Reply:

yes. This is the case where the user really wants to log out from this session

this is the "Clear all data" button from:

image

@anoadragon453
Copy link
Member

Should be fixed by #7443 in v1.14.0.

@bmarty
Copy link

bmarty commented Jun 8, 2020

I confirmed it's fixed. And device is correctly deleted on the homeserver

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants