-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me other than the code styling problem. My ask @richvdh to double check this makes sense from an SSO/CAS PoV
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks generally good, a couple of comments though
Signed-off-by: Valérian Rousset <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me other than a tweak to the changelog wording!
Co-Authored-By: Richard van der Hoff <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for the contribution!
Now, the CAS server can return an attribute stating what's the desired displayname, instead of using the username directly.
btw, one nice config block for cas' attributes would be
but that would break existing config.