Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

cas: support setting display name #6114

Merged
merged 2 commits into from
Oct 11, 2019
Merged

cas: support setting display name #6114

merged 2 commits into from
Oct 11, 2019

Conversation

tharvik
Copy link
Contributor

@tharvik tharvik commented Sep 26, 2019

Now, the CAS server can return an attribute stating what's the desired displayname, instead of using the username directly.

btw, one nice config block for cas' attributes would be

cas_config:
    server_url: "https://cas-server.com"
    service_url: "https://homeserver.domain.com:8448"
    attributes:
        display_name: name
        required:
            name: value

but that would break existing config.

@richvdh richvdh requested a review from a team October 3, 2019 11:31
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me other than the code styling problem. My ask @richvdh to double check this makes sense from an SSO/CAS PoV

synapse/rest/client/v1/login.py Outdated Show resolved Hide resolved
@richvdh richvdh self-requested a review October 9, 2019 20:21
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks generally good, a couple of comments though

synapse/rest/client/v1/login.py Outdated Show resolved Hide resolved
synapse/config/cas.py Outdated Show resolved Hide resolved
Signed-off-by: Valérian Rousset <[email protected]>
@richvdh richvdh self-requested a review October 11, 2019 08:45
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me other than a tweak to the changelog wording!

changelog.d/6114.feature Outdated Show resolved Hide resolved
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for the contribution!

@richvdh richvdh merged commit be9b55e into matrix-org:develop Oct 11, 2019
@tharvik tharvik deleted the cas_set-displayname branch October 11, 2019 12:01
babolivier pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants