Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Fix up some typechecking #6150

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Fix up some typechecking #6150

merged 2 commits into from
Oct 2, 2019

Conversation

hawkowl
Copy link
Contributor

@hawkowl hawkowl commented Oct 2, 2019

Splitting some stuff out from the other PR that now fails when we properly typecheck synapse/config/...

@hawkowl hawkowl requested a review from a team October 2, 2019 11:21
@hawkowl hawkowl merged commit 864f144 into develop Oct 2, 2019
@hawkowl hawkowl deleted the hawkowl/type-checking-madness branch October 2, 2019 12:29
@kyrias
Copy link
Contributor

kyrias commented Nov 3, 2019

Since synapse doesn't seem to use any of the "experimental" things that haven't yet been added to the typing module, could this dependency be made conditional on the python version instead?

babolivier pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants