Synapse sends unnecessary device list change entries

[dbkr]

With the lazy loading sync options enabled, synapse includes the current state events it thinks the client will need in order to render the events in the timeline section. The device list sync computation code includes these state events when working out what users have joined a room, so every time this happens, it generates a device change entry for that user too.

This will also presumably have happened when a user changed their profile information, so perhaps the most sensible fix here is for the sync code to look at the prev content for join events (it already looks at prev_content for leave events: https://github.com/matrix-org/synapse/blob/master/synapse/handlers/sync.py#L1382 ).

[ara4n]

See also #3829

[ara4n]

See also #7524. We shouldn't even be sending device list updates for users who you're not encrypting with.