Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Guest accounts should expire #669

Open
fladd opened this issue Mar 26, 2016 · 10 comments
Open

Guest accounts should expire #669

fladd opened this issue Mar 26, 2016 · 10 comments
Labels
A-Guests O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.

Comments

@fladd
Copy link

fladd commented Mar 26, 2016

Currently, guest accounts will not expire, which leads to them cluttering up rooms, even though no one is using these accounts anymore.

Since the whole idea of guest accounts is that of a temporary life-span, this should be reflected in how they are handled server-side.

I propose that guest accounts automatically expire/leave all rooms they are in, if either:

a) The user goes offline

or

b) The account has no activity for 24 hours

@rokups
Copy link

rokups commented Nov 22, 2016

I second this. One room i am maintaining has over 500 hundred participants, but in reality its several tens of actual active users. Rest of them are guest accounts. Whats even more funny is that same person coming to chat multiple times picks same alias, but if he does not register then room contains 10 participants with same alias and they will never be coming back.

@gonight
Copy link

gonight commented Dec 27, 2016

Is there any known fix or workaround for this yet?

@Bitti09
Copy link

Bitti09 commented Mar 12, 2017

Any update or workaround for this ?

@eMPee584
Copy link

eMPee584 commented Apr 4, 2019

Is just deleting from users WHERE is_guest == 1 an appropriate shortcut?

@a-fellerer
Copy link

This feature would be great!

@clokep clokep added z-feature (Deprecated Label) z-p3 (Deprecated Label) labels Jun 22, 2020
@KlaasT
Copy link

KlaasT commented Jan 11, 2021

Is there already any update on this or a workaround? In the meantime so many garbage users have accumulated and they are bridged over to IRC. I just don't want to edit the database directly.

@clokep
Copy link
Member

clokep commented Jan 11, 2021

The proposed solution sounds reasonable, but the synapse team won't have time to work on this in the near future. We would definitely review a pull request adding some configuration options on handling guest users in the above manner.

@maurerbot
Copy link

👍 I'm using a shields.io badge and guests hanging around isn't great.

@erikjohnston erikjohnston added T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. and removed z-feature (Deprecated Label) labels Sep 22, 2021
@rwjack
Copy link

rwjack commented Nov 23, 2021

https://github.com/Awesome-Technologies/synapse-admin

^ Workaround for the time being, but yeah, another +1 on the purge old guest users feature.
Maybe have an option to create a limit inside which the guest users are rotated, 500 max guest users, when 501 is created, delete 001, etc...

@DMRobertson DMRobertson added P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches and removed z-p3 (Deprecated Label) labels Nov 24, 2021
@cjaone
Copy link

cjaone commented Feb 19, 2022

Just my 2 cents: Daily use of a chat room is very common. I'm not sure: When I join at 8am as a guest, stay for 8 hours and come back the next morning at 8am as a guest will the old account still be visible the whole day if expiration was set to 24 hours after the last actitvity? If yes, then for every guest account who does that there will always be a second "ghost" account in parallel if it was present yesterday. So maybe 12 hours (as a default) should be sufficient, what do you think?

@DMRobertson DMRobertson added S-Minor Blocks non-critical functionality, workarounds exist. A-Guests O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P3 (OBSOLETE: use S- labels.) Approved backlog: not yet scheduled, will accept patches labels Oct 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Guests O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Blocks non-critical functionality, workarounds exist. T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements.
Projects
None yet
Development

No branches or pull requests