You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
As per #8238 we have docs that say to repopulate the room stats table you can insert populate_stats_process_rooms into the background job table. This is a bit icky as a) its not obvious that background jobs are a "public API" and b) if we add further background jobs that depend on populate_stats_process_rooms those will not get re-run (which might lead to bugs).
This feels like something that should be an admin API, or some other form of explicit API, to avoid the above issues.
(Note: we do have tests that manually inserting populate_stats_process_rooms does the Right Thing, but since its not obvious that its a "public API" the tests may just be modified, which is what allowed the regression in #8238)
The text was updated successfully, but these errors were encountered:
As per #8238 we have docs that say to repopulate the room stats table you can insert
populate_stats_process_rooms
into the background job table. This is a bit icky as a) its not obvious that background jobs are a "public API" and b) if we add further background jobs that depend onpopulate_stats_process_rooms
those will not get re-run (which might lead to bugs).This feels like something that should be an admin API, or some other form of explicit API, to avoid the above issues.
(Note: we do have tests that manually inserting
populate_stats_process_rooms
does the Right Thing, but since its not obvious that its a "public API" the tests may just be modified, which is what allowed the regression in #8238)The text was updated successfully, but these errors were encountered: