This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Add contributer docs for using the provided linters script #6164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are required when running the `lint.sh` dev scripts. Signed-off-by: Jason Robinson <[email protected]>
Add also to the pull request template to avoid build failures due to people not knowing that linters need running. Signed-off-by: Jason Robinson <[email protected]>
anoadragon453
suggested changes
Oct 7, 2019
Co-Authored-By: Andrew Morgan <[email protected]>
Co-Authored-By: Andrew Morgan <[email protected]>
Signed-off-by: Jason Robinson <[email protected]>
|
Comments addressed! |
hawkowl
approved these changes
Nov 1, 2019
babolivier
pushed a commit
that referenced
this pull request
Sep 1, 2021
* commit '67a65918a': Add contributer docs for using the provided linters script (#6164)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add also to the pull request template to avoid build failures due
to people not knowing that linters need running.
Add lint dependencies black, flake8 and isort.
These are required when running the
lint.shdev scripts.