Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When bootstrapping, check the user's namespace first with their own branch before falling back on matrix-org #1173

Open
ShadowJonathan opened this issue Nov 29, 2021 · 2 comments

Comments

@ShadowJonathan
Copy link
Contributor

wget -q https://github.com/matrix-org/sytest/archive/$branch_name.tar.gz -O sytest.tar.gz || {

Edit that to first check user_repo/sytest@user_branch, before going to matrix-org/sytest@user_branch and then matrix-org/sytest@develop

@richvdh
Copy link
Member

richvdh commented Dec 9, 2021

I have a feeling we avoided this because "security" (something to do with untrusted code in CI). But possibly that was pre-GHA, and is no longer a problem?

handwave. I can't really remember.

@ShadowJonathan
Copy link
Contributor Author

Maybe it could still become a security concern if/when matrix.org adds their own self-hosted runners to the GHA pool, though maybe that could be re-routed for untrusted PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants