Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bidirectional model #118

Merged
merged 10 commits into from
Feb 25, 2025
Merged

Add bidirectional model #118

merged 10 commits into from
Feb 25, 2025

Conversation

willdumm
Copy link
Contributor

@willdumm willdumm commented Feb 14, 2025

Implements #116.
This will only work for full-length sequences, because of the way we reverse only the non-padding parts of the data.

@willdumm willdumm force-pushed the 116-bidirectional-model branch from 905ea65 to 864b247 Compare February 24, 2025 22:44
@willdumm willdumm marked this pull request as ready for review February 24, 2025 22:48
@willdumm willdumm requested a review from matsen February 25, 2025 15:59
Copy link
Contributor

@matsen matsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@willdumm willdumm merged commit a571cb9 into main Feb 25, 2025
2 checks passed
@willdumm willdumm deleted the 116-bidirectional-model branch February 25, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants