Replacing normalize_sub_probs with a check; fixing consistency problems #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
willdumm
reviewed
Oct 30, 2024
willdumm
approved these changes
Oct 30, 2024
matsen
commented
Oct 30, 2024
There was a problem hiding this comment.
Whelp, this ended up being a little strange.
This makes sense:
for nt_parent, mask, nt_rates, nt_csps, branch_length in zip(
self.nt_parents,
self.masks,
self.nt_ratess,
self.nt_cspss,
self._branch_lengths,OTOH, when we get a batch that also has a batch dimension but we just call it singular. I tried adding plural everywhere but it was just strange. PyTorch magic should make it feel like the batch dimension isn't there. But then why do plural ever?
Conclusion: enough already 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalize_sub_probs(making a CSP out of something not normalized) hasn't been necessary since we switched to netam SHM models. Here we replace that with a check.