Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When to drop Ruby 1.9 support? #16

Closed
mattbrictson opened this issue May 24, 2015 · 2 comments
Closed

When to drop Ruby 1.9 support? #16

mattbrictson opened this issue May 24, 2015 · 2 comments
Labels

Comments

@mattbrictson
Copy link
Owner

Airbrussh currently runs fine on Ruby 1.9 and up. However since Ruby's maintainers have officially dropped all support for 1.9, it doesn't really make sense to devote our time to supporting a dead version of Ruby.

Can Airbrussh safely stop supporting 1.9? Are there a lot of Airbrussh users still on 1.9? (Seems there is at least one.)

Suggestions, speculation, and discussion welcome! 😃

Here are some ideas:

  • Maintain 1.9 support as long as SSHKit and Capistrano do
  • Drop 1.9 support now (no time like the present!)
  • Wait until Airbrussh 1.0 (which will be…?)

/cc @robd @carlesso

@robd
Copy link
Contributor

robd commented May 25, 2015

When I initially mentioned ruby versions, I hadn't realised that we supported it. In actual fact, I haven't found any cases where it was an issue (apart from adding a missing UTF-8 comment to a test). Unless it starts becoming an overhead, I reckon we should support it in versions where SSHKit supports it, especially if we are going to try and get Airbrussh merged into SSHKit.

@mattbrictson
Copy link
Owner Author

Good points. Let's track SSHKit and keep 1.9 support around as long as SSHKit does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants