Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to react-router@2 #3

Open
bguiz opened this issue Apr 7, 2016 · 7 comments
Open

Update to react-router@2 #3

bguiz opened this issue Apr 7, 2016 · 7 comments

Comments

@bguiz
Copy link

bguiz commented Apr 7, 2016

Initially left a comment here, but feel more appropriate to raise an issue here.

@doctyper It seems that several of us here are having issues. Just
confirming that you are using it for server rendering as well?

If so, could you please update the react-helmet-example to use
react-router@2 (it's currently using [email protected]):
https://github.com/mattdennewitz/react-helmet-example/blob/master/package.json#L12

... and then I'd like to see what is done differently when rendering
on the server: https://github.com/mattdennewitz/react-helmet-example/blob/master/server.js#L30-L48

CC @mattdennewitz

@aybmab
Copy link

aybmab commented Sep 19, 2016

Any updates?

@mattdennewitz
Copy link
Owner

Sure, will take this on shortly.

@asiniy
Copy link

asiniy commented Oct 29, 2016

?

@vignestion
Copy link

Well take a look at this. @aybmab @bguiz
React-helmet example app

@aybmab
Copy link

aybmab commented Nov 21, 2016

Not sure if they fixed it, but my team found a memory leak using react helmet. I ended up just building my own custom solution, which is actually pretty easy/straight-forward.

@doctyper
Copy link

@aybmab Interesting. Please open a ticket in react-helmet if you're still experiencing this leak.

@mattdennewitz
Copy link
Owner

Anyone interested in implementing React Router 3 or 4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants