-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to react-router@2 #3
Comments
Any updates? |
Sure, will take this on shortly. |
? |
Well take a look at this. @aybmab @bguiz |
Not sure if they fixed it, but my team found a memory leak using react helmet. I ended up just building my own custom solution, which is actually pretty easy/straight-forward. |
@aybmab Interesting. Please open a ticket in react-helmet if you're still experiencing this leak. |
Anyone interested in implementing React Router 3 or 4? |
Initially left a comment here, but feel more appropriate to raise an issue here.
@doctyper It seems that several of us here are having issues. Just
confirming that you are using it for server rendering as well?
If so, could you please update the react-helmet-example to use
react-router@2 (it's currently using [email protected]):
https://github.com/mattdennewitz/react-helmet-example/blob/master/package.json#L12
... and then I'd like to see what is done differently when rendering
on the server: https://github.com/mattdennewitz/react-helmet-example/blob/master/server.js#L30-L48
CC @mattdennewitz
The text was updated successfully, but these errors were encountered: