Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple blocks per batch #363

Open
itegulov opened this issue Oct 29, 2024 · 1 comment
Open

feat: allow multiple blocks per batch #363

itegulov opened this issue Oct 29, 2024 · 1 comment

Comments

@itegulov
Copy link
Contributor

itegulov commented Oct 29, 2024

Current implementation seals a batch after every single miniblock (and hence after every single tx). Motivation to resolve this is very similar to what is outlined in "Allow multiple txs per block" but there is an extra benefit in that we will stop producing empty blocks after every single real block. Which results in latest block never having any txs in the current implementation.

I propose we allow two modes of operation:

  • Manual batch sealing via debug_sealBatch (just an example, namespace + name to be decided)
  • Automatic batch sealing every so often (configurable on startup)

NOTE: A major problem with this is that we can't mix impersonated and non-impersonated transactions inside a single batch due to limitation of our current approach (batch VM is initialized with either normal or impersonated transactions at the start of a batch).

@itegulov itegulov converted this from a draft issue Oct 29, 2024
@itegulov itegulov changed the title Allow multiple blocks per batch feat: allow multiple blocks per batch Nov 22, 2024
@itegulov
Copy link
Contributor Author

Marking this as blocked as I feel like the design here is heavily dependent on #407

@itegulov itegulov moved this from Todo to Blocked in DevEx squad Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

No branches or pull requests

1 participant