feat(eth-sender): make base fee grow at least as fast as priority fee #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perekopskiy
approved these changes
Dec 13, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tomg10
deleted the
make-priority-fees-not-grow-faster-than-base-fee-on-resend
branch
randomsuperher
pushed a commit
that referenced
this pull request
Jan 17, 2025
🤖 I have created a release *beep* *boop* --- ## [26.0.0](core-v25.4.0...core-v26.0.0) (2025-01-17) ### ⚠ BREAKING CHANGES * **contracts:** gateway integration ([#1934](#1934)) ### Features * Adapt server for new EVM bytecode hash encoding ([#3396](#3396)) ([5a1e6d2](5a1e6d2)) * Add logging & metrics for mempool ([#3447](#3447)) ([64d861d](64d861d)) * **api_server:** report gas price based on open batch ([#2868](#2868)) ([f30aca0](f30aca0)) * **contracts:** gateway integration ([#1934](#1934)) ([f06cb79](f06cb79)) * da_dispatcher refactoring ([#3409](#3409)) ([591cd86](591cd86)) * **en:** make documentation more chain agnostic ([#3376](#3376)) ([361243f](361243f)) * **eth-sender:** make base fee grow at least as fast as priority fee ([#3386](#3386)) ([78af2bf](78af2bf)) * **eth-watch:** Change protocol upgrade schema ([#3435](#3435)) ([2c778fd](2c778fd)) * Features for an easier upgrade ([#3422](#3422)) ([3037ee6](3037ee6)) * FFLONK support for compressor ([#3359](#3359)) ([1a297be](1a297be)) * pubdata type changes from sync-layer-stable ([#3425](#3425)) ([f09087b](f09087b)) ### Bug Fixes * **api:** Propagate fallback errors in traces ([#3469](#3469)) ([84e3e31](84e3e31)) * **en:** make EN use main node's fee input ([#3489](#3489)) ([cbf2c31](cbf2c31)) * eth aggregator restriction ([#3490](#3490)) ([6cc9b9e](6cc9b9e)) ### Performance Improvements * **eth-sender:** optimize sql query ([#3437](#3437)) ([0731f60](0731f60)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Tomasz Grześkiewicz <[email protected]> Co-authored-by: zksync-era-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a limit on priority fee, if an eth-sender transaction hits it, we panic. Currently eth-sender transactions may in some very rare situations hit this limits as base_fees may grow slower than priority_fees (it happened today), this change forces base_fee to grow at least as fast as priority fee.