fix(en): Fix race condition in EN storage initialization #3515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itegulov
approved these changes
Jan 23, 2025
popzxc
approved these changes
Jan 23, 2025
slowli
deleted the
aov-pla-1083-fix-race-condition-in-en-storage-initialization
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 24, 2025
🤖 I have created a release *beep* *boop* --- ## [26.2.0](core-v26.1.0...core-v26.2.0) (2025-01-24) ### Features * Compressor optimizations ([#3476](#3476)) ([3e931be](3e931be)) ### Bug Fixes * **en:** better defaults, i.e. the same as used by main node ([#3521](#3521)) ([2b5fe98](2b5fe98)) * **en:** Fix race condition in EN storage initialization ([#3515](#3515)) ([c916797](c916797)) * JSON proof serialization ([#3514](#3514)) ([516e521](516e521)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <[email protected]> Co-authored-by: Anton Baliasnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Reworks
NodeStorageInitializer::is_chain_tip_correct()so that it performs the minimum amount of work possible, i.e. detects whether the latest L1 batch / L2 block diverge or not.Why ❔
EN storage initialization is prone to a data race: the "is storage initialized" check calls
NodeStorageInitializer::is_chain_tip_correct(), which internally performs the entire iteration of the reorg detector (in particular, binary search for the first diverged block). This can lead to a data race with block revert logic, which may be executed concurrently. This data race was observed on the revert integration tests.Checklist
zkstack dev fmtandzkstack dev lint.