Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added consensus types and consensus column to miniblocks table #490

Merged
merged 11 commits into from
Nov 16, 2023

Conversation

pompon0
Copy link
Contributor

@pompon0 pompon0 commented Nov 14, 2023

To execute consensus on miniblocks we need to store extra data per miniblock.

@pompon0 pompon0 requested a review from slowli November 14, 2023 12:33
@pompon0 pompon0 changed the title added consensus types and consensus column to miniblocks table feat: added consensus types and consensus column to miniblocks table Nov 14, 2023
@pompon0 pompon0 requested a review from slowli November 14, 2023 20:44
core/lib/dal/Cargo.toml Outdated Show resolved Hide resolved
@pompon0 pompon0 requested a review from slowli November 15, 2023 14:42
@pompon0 pompon0 marked this pull request as ready for review November 15, 2023 14:42
@pompon0 pompon0 requested a review from a team as a code owner November 15, 2023 14:42
Copy link
Contributor

@slowli slowli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than compilation problems (IIUC, related to selecting the tokio version), looks good.

core/lib/zksync_core/src/consensus/proto/mod.proto Outdated Show resolved Hide resolved
core/lib/types/src/block.rs Show resolved Hide resolved
@pompon0 pompon0 requested a review from slowli November 16, 2023 09:47
@pompon0 pompon0 enabled auto-merge November 16, 2023 10:14
@slowli slowli disabled auto-merge November 16, 2023 11:36
@pompon0 pompon0 added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit f9ae0ad Nov 16, 2023
21 checks passed
@pompon0 pompon0 deleted the gprusak-consensus-types branch November 16, 2023 14:30
github-merge-queue bot pushed a commit that referenced this pull request Nov 21, 2023
🤖 I have created a release *beep* *boop*
---


##
[18.1.0](core-v18.0.3...core-v18.1.0)
(2023-11-20)


### Features

* added consensus types and consensus column to miniblocks table
([#490](#490))
([f9ae0ad](f9ae0ad))
* Adds `prover_group_id` label into `fri_prover_prover_job` metric
([#503](#503))
([851e800](851e800))
* **core:** adds a get proof endpoint in zks namespace to http endpoint
on main node
([#504](#504))
([0ac4a4d](0ac4a4d))
* **merkle tree:** Allow random-order tree recovery
([#485](#485))
([146e4cf](146e4cf))


### Bug Fixes

* **core:** add tree url to jsonrpsee server on main node
([#512](#512))
([7c137b7](7c137b7))
* Fixes panic on unknown FRI prover group id
([#522](#522))
([1c315f3](1c315f3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants