-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added consensus types and consensus column to miniblocks table #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pompon0
changed the title
added consensus types and consensus column to miniblocks table
feat: added consensus types and consensus column to miniblocks table
Nov 14, 2023
slowli
reviewed
Nov 14, 2023
slowli
reviewed
Nov 15, 2023
…bs/zksync-era into gprusak-consensus-types
slowli
reviewed
Nov 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than compilation problems (IIUC, related to selecting the tokio
version), looks good.
slowli
approved these changes
Nov 16, 2023
RomanBrodetski
approved these changes
Nov 16, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
🤖 I have created a release *beep* *boop* --- ## [18.1.0](core-v18.0.3...core-v18.1.0) (2023-11-20) ### Features * added consensus types and consensus column to miniblocks table ([#490](#490)) ([f9ae0ad](f9ae0ad)) * Adds `prover_group_id` label into `fri_prover_prover_job` metric ([#503](#503)) ([851e800](851e800)) * **core:** adds a get proof endpoint in zks namespace to http endpoint on main node ([#504](#504)) ([0ac4a4d](0ac4a4d)) * **merkle tree:** Allow random-order tree recovery ([#485](#485)) ([146e4cf](146e4cf)) ### Bug Fixes * **core:** add tree url to jsonrpsee server on main node ([#512](#512)) ([7c137b7](7c137b7)) * Fixes panic on unknown FRI prover group id ([#522](#522)) ([1c315f3](1c315f3)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To execute consensus on miniblocks we need to store extra data per miniblock.