fix(house_keeper): Emit the correct circuit_id for aggregation round 2 #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is us hardcoding the circuit_id to 2 for aggregation_round 2. This fix is useless as soon as we change the config (not expected anytime soon). A real fix will follow where we address what is saved in database layer and this patch will be removed altogether. This is necessary to enable autoscaler to work (emits the correct data for prover groups, which in turn can be picked by autoscaler).
yorik
previously approved these changes
Nov 27, 2023
Deniallugo
approved these changes
Nov 27, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
🤖 I have created a release *beep* *boop* --- ## [18.3.0](core-v18.2.0...core-v18.3.0) (2023-11-28) ### Features * **contract-verifier:** Add zkvyper 1.3.13 ([#552](#552)) ([198deda](198deda)) ### Bug Fixes * **house_keeper:** Emit the correct circuit_id for aggregation round 2 ([#547](#547)) ([9cada1a](9cada1a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This is us hardcoding the circuit_id to 2 for aggregation_round 2. This fix is useless as soon as we change the config (not expected anytime soon).
A real fix will follow where we address what is saved in database layer and this patch will be removed altogether.
Why ❔
This is necessary to enable autoscaler to work (emits the correct data for prover groups, which in turn can be picked by autoscaler).
Checklist
zk fmtandzk lint.