Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Add metrics for jsonrpsee subscriptions #733

Merged

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Dec 21, 2023

What ❔

A small follow-up PR for #693 that introduces some metrics allowing to track the health of the new approach. Also, does minor refactoring for the API server builder so it's more typesafe.

Why ❔

Observability and maintainability.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.
  • Spellcheck has been run via cargo spellcheck --cfg=./spellcheck/era.cfg --code 1.

@slowli slowli marked this pull request as ready for review December 22, 2023 08:51
@montekki montekki added this pull request to the merge queue Dec 22, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 22, 2023
@slowli slowli added this pull request to the merge queue Dec 22, 2023
Merged via the queue into main with commit 39fd71c Dec 22, 2023
26 checks passed
@slowli slowli deleted the aov-pla-673-implement-subscriptions-using-jsonrpsee-chores branch December 22, 2023 10:11
RomanBrodetski pushed a commit that referenced this pull request Dec 25, 2023
🤖 I have created a release *beep* *boop*
---


##
[18.10.0](core-v18.9.0...core-v18.10.0)
(2023-12-25)


### Features

* **api:** Add metrics for `jsonrpsee` subscriptions
([#733](#733))
([39fd71c](39fd71c))
* **api:** remove jsonrpc backend
([#693](#693))
([b3f0417](b3f0417))
* applied status snapshots dal
([#679](#679))
([2e9f23b](2e9f23b))
* **en:** Make reorg detector work with pruned data
([#712](#712))
([c4185d5](c4185d5))
* Remove data fetchers
([#694](#694))
([f48d677](f48d677))
* Remove zks_getConfirmedTokens method
([#719](#719))
([9298b1b](9298b1b))


### Bug Fixes

* added waiting for prometheus to finish
([#745](#745))
([eed330d](eed330d))
* **EN:** temporary produce a warning on pubdata mismatch with L1
([#758](#758))
([0a7a4da](0a7a4da))
* **prover:** Add logging for prover + WVGs
([#723](#723))
([d7ce14c](d7ce14c))
* remove leftovers after
[#693](#693)
([#720](#720))
([e93aa35](e93aa35))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants