Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-63189] Dependencies update #80

Merged
merged 3 commits into from
Feb 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.61.0
version: v1.64.5
29 changes: 4 additions & 25 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,31 +6,10 @@ linters-settings:
gofmt:
simplify: true
govet:
check-shadowing: false # set this to true from time to time to check for possible issues
disable-all: true
enable:
- asmdecl # report mismatches between assembly files and Go declarations
- assign # check for useless assignments
- atomic # check for common mistakes using the sync/atomic package
- bools # check for common mistakes involving boolean operators
- buildtag # check that +build tags are well-formed and correctly located
- cgocall # detect some violations of the cgo pointer passing rules
- composites # check for unkeyed composite literals
- copylocks # check for locks erroneously passed by value
- errorsas # report passing non-pointer or non-error values to errors.As
- httpresponse # check for mistakes using HTTP responses
- loopclosure # check references to loop variables from within nested functions
- lostcancel # check cancel func returned by context.WithCancel is called
- nilfunc # check for useless comparisons between functions and nil
- printf # check consistency of Printf format strings and arguments
- shift # check for shifts that equal or exceed the width of the integer
- stdmethods # check signature of methods of well-known interfaces
- structtag # check that struct field tags conform to reflect.StructTag.Get
- tests # check for common mistaken usages of tests and examples
- unmarshal # report passing non-pointer or non-interface values to unmarshal
- unreachable # check for unreachable code
- unsafeptr # check for invalid conversions of uintptr to unsafe.Pointer
- unusedresult # check for unused results of calls to some functions
enable-all: true
disable:
- fieldalignment
- shadow

linters:
disable-all: true
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ DOCKER_USER ?= user
DOCKER_PASSWORD ?= password
# Docker Images
DOCKER_IMAGE_GO += "golang:${GO_VERSION}"
DOCKER_IMAGE_GOLINT += "golangci/golangci-lint:v1.60.0@sha256:e47065d755ca0afeac9df866d1dabdc99f439653a43fe234e05f50d9c36b6b90"
DOCKER_IMAGE_GOLINT += "golangci/golangci-lint:v1.64.5@sha256:9faef4dda4304c4790a14c5b8c8cd8c2715a8cb754e13f61d8ceaa358f5a454a"
DOCKER_IMAGE_DOCKERLINT += "hadolint/hadolint:v2.12.0@sha256:9259e253a4e299b50c92006149dd3a171c7ea3c5bd36f060022b5d2c1ff0fbbe"
DOCKER_IMAGE_COSIGN += "bitnami/cosign:1.8.0@sha256:8c2c61c546258fffff18b47bb82a65af6142007306b737129a7bd5429d53629a"
DOCKER_IMAGE_GH_CLI += "ghcr.io/supportpal/github-gh-cli:2.31.0@sha256:71371e36e62bd24ddd42d9e4c720a7e9954cb599475e24d1407af7190e2a5685"
Expand Down
2 changes: 1 addition & 1 deletion cmd/recorder/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ func (rec *Recorder) postJobStatus(status public.JobStatus) error {
defer cancelCtx()
resp, err := rec.client.DoAPIRequestBytes(ctx, http.MethodPost, apiURL, payload, "")
if err != nil {
return fmt.Errorf("request failed%w", err)
return fmt.Errorf("request failed: %w", err)
}
defer resp.Body.Close()
cancelCtx()
Expand Down
8 changes: 4 additions & 4 deletions cmd/recorder/upload_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ func TestUploadRecording(t *testing.T) {
},
}
err := rec.uploadRecording()
require.EqualError(t, err, "failed to create upload: AppErrorFromJSON: model.utils.decode_json.app_error, body: Internal Server Error\n, invalid character 'I' looking for beginning of value")
require.EqualError(t, err, "failed to create upload: failed to decode JSON payload into AppError. Body: Internal Server Error\n: invalid character 'I' looking for beginning of value")
})

t.Run("upload creation failure", func(t *testing.T) {
Expand All @@ -82,7 +82,7 @@ func TestUploadRecording(t *testing.T) {
},
}
err := rec.uploadRecording()
require.EqualError(t, err, "failed to create upload: : server error")
require.EqualError(t, err, "failed to create upload: server error")
})

t.Run("upload data failure", func(t *testing.T) {
Expand All @@ -106,7 +106,7 @@ func TestUploadRecording(t *testing.T) {
},
}
err := rec.uploadRecording()
require.EqualError(t, err, "failed to upload data: : server error")
require.EqualError(t, err, "failed to upload data: server error")
})

t.Run("save recording failure", func(t *testing.T) {
Expand Down Expand Up @@ -138,7 +138,7 @@ func TestUploadRecording(t *testing.T) {
},
}
err := rec.uploadRecording()
require.EqualError(t, err, "failed to save recording: : server error")
require.EqualError(t, err, "failed to save recording: server error")
})

t.Run("success", func(t *testing.T) {
Expand Down
47 changes: 29 additions & 18 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -6,43 +6,54 @@ require (
github.com/chromedp/cdproto v0.0.0-20240202021202-6d0b6a386732
github.com/chromedp/chromedp v0.9.5
github.com/mattermost/mattermost-plugin-calls/server/public v0.0.3-0.20231103204030-06bd54bcfa67
github.com/mattermost/mattermost/server/public v0.0.0-20230613002302-62a3ee8adcb5
github.com/stretchr/testify v1.8.4
github.com/mattermost/mattermost/server/public v0.1.10
github.com/stretchr/testify v1.10.0
golang.org/x/time v0.0.0-20181108054448-85acf8d2951c
)

require (
github.com/blang/semver v3.5.1+incompatible // indirect
github.com/blang/semver/v4 v4.0.0 // indirect
github.com/chromedp/sysutil v1.0.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/davecgh/go-spew v1.1.2-0.20180830191138-d8f796af33cc // indirect
github.com/dyatlov/go-opengraph/opengraph v0.0.0-20220524092352-606d7b1e5f8a // indirect
github.com/fatih/color v1.18.0 // indirect
github.com/francoispqt/gojay v1.2.13 // indirect
github.com/gobwas/httphead v0.1.0 // indirect
github.com/gobwas/pool v0.2.1 // indirect
github.com/gobwas/ws v1.3.2 // indirect
github.com/google/uuid v1.3.0 // indirect
github.com/gorilla/websocket v1.5.0 // indirect
github.com/graph-gophers/graphql-go v1.5.1-0.20230110080634-edea822f558a // indirect
github.com/golang/protobuf v1.5.4 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/gorilla/websocket v1.5.3 // indirect
github.com/hashicorp/errwrap v1.1.0 // indirect
github.com/hashicorp/go-hclog v1.6.3 // indirect
github.com/hashicorp/go-multierror v1.1.1 // indirect
github.com/hashicorp/go-plugin v1.6.3 // indirect
github.com/hashicorp/yamux v0.1.2 // indirect
github.com/josharian/intern v1.0.0 // indirect
github.com/mailru/easyjson v0.7.7 // indirect
github.com/mattermost/go-i18n v1.11.1-0.20211013152124-5c415071e404 // indirect
github.com/mattermost/ldap v3.0.4+incompatible // indirect
github.com/mattermost/logr/v2 v2.0.16 // indirect
github.com/mattermost/logr/v2 v2.0.21 // indirect
github.com/mattn/go-colorable v0.1.14 // indirect
github.com/mattn/go-isatty v0.0.20 // indirect
github.com/oklog/run v1.1.0 // indirect
github.com/pborman/uuid v1.2.1 // indirect
github.com/pelletier/go-toml v1.9.5 // indirect
github.com/philhofer/fwd v1.1.2 // indirect
github.com/philhofer/fwd v1.1.3-0.20240916144458-20a13a1f6b7c // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/rogpeppe/go-internal v1.10.0 // indirect
github.com/tinylib/msgp v1.1.8 // indirect
github.com/vmihailenco/msgpack/v5 v5.3.5 // indirect
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
github.com/tinylib/msgp v1.2.5 // indirect
github.com/vmihailenco/msgpack/v5 v5.4.1 // indirect
github.com/vmihailenco/tagparser/v2 v2.0.0 // indirect
github.com/wiggin77/merror v1.0.4 // indirect
github.com/wiggin77/merror v1.0.5 // indirect
github.com/wiggin77/srslog v1.0.1 // indirect
golang.org/x/crypto v0.8.0 // indirect
golang.org/x/net v0.9.0 // indirect
golang.org/x/sys v0.16.0 // indirect
golang.org/x/text v0.9.0 // indirect
golang.org/x/crypto v0.32.0 // indirect
golang.org/x/net v0.34.0 // indirect
golang.org/x/sys v0.29.0 // indirect
golang.org/x/text v0.21.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20250124145028-65684f501c47 // indirect
google.golang.org/grpc v1.70.0 // indirect
google.golang.org/protobuf v1.36.4 // indirect
gopkg.in/asn1-ber.v1 v1.0.0-20181015200546-f715ec2f112d // indirect
gopkg.in/natefinch/lumberjack.v2 v2.2.1 // indirect
gopkg.in/yaml.v2 v2.4.0 // indirect
Expand Down
Loading
Loading