Improved configuration validation #278
Conversation
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func TestBotConfig_IsValid(t *testing.T) { |
There was a problem hiding this comment.
There isn't a success case. So a function that always fails will pass. (Which is the current case)
| } | ||
|
|
||
| // Validate access levels are within bounds | ||
| if c.ChannelAccessLevel < ChannelAccessLevelAll || c.ChannelAccessLevel > ChannelAccessLevelNone { |
There was a problem hiding this comment.
This is backwards. UserAccessLevelAll = 0 and ChannelAccessLevelNone = 3
There was a problem hiding this comment.
I'm not sure I understand your comment.
ChannelAccessLevelAll = 0 and ChannelAccessLevelNone = 3. The code checks that the value passed to it is not less than 0 and not greater than 3. Is that not correct?
| if c.ChannelAccessLevel < ChannelAccessLevelAll || c.ChannelAccessLevel > ChannelAccessLevelNone { | ||
| return false | ||
| } | ||
| if c.UserAccessLevel < UserAccessLevelAll || c.UserAccessLevel > UserAccessLevelNone { |
There was a problem hiding this comment.
UserAccessLevelAll = 0 and UserAccessLevelNone = 3. The code checks that the value passed to it is not less than 0 and not greater than 3. Is that not correct?
There was a problem hiding this comment.
Yes I read those wrong. Don't do code reviews while jet-legged kids 🛫
| @@ -49,10 +57,30 @@ type BotConfig struct { | |||
| } | |||
|
|
|||
| func (c *BotConfig) IsValid() bool { | |||
There was a problem hiding this comment.
It might be nice to have this return an error with a specific failure. (I bet Aider could make this change pretty quick)
server/ai/configuration.go
Outdated
| // Service-specific validation | ||
| switch c.Service.Type { | ||
| case ServiceTypeOpenAI: | ||
| return c.Service.APIKey != "" && c.Service.OrgID != "" |
Description