Skip to content
This repository has been archived by the owner on May 27, 2024. It is now read-only.

Remove external shell script support #23

Open
ghost opened this issue Jun 27, 2022 · 0 comments
Open

Remove external shell script support #23

ghost opened this issue Jun 27, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Jun 27, 2022

Using external scripts increase complexity and may introduce security holes in the system.

Remove script files support and define script body in the command configuration files.

Replace below block

exec: 
    - scripts/release/cut-release-branch.sh

with

exec: 
    - script: |
        git push --dry-run 
  
        deleteRepo
        
        jq  --null-input \
            --arg status "$STATUS" \
            --arg branch "$BRANCH_DEST" \
            --arg branch_mobile "$BRANCH_DEST_MOBILE" \
            --arg version "$SEMVER_RELEASE" \
            '{"status": $status, "data": { "SEMVER_RELEASE": $version,"BRANCH_DEST": $branch,"BRANCH_DEST_MOBILE": $branch_mobile }}'
@ghost ghost added this to the 0.0.1 milestone Jun 27, 2022
@ghost ghost added bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jun 27, 2022
@ghost ghost assigned ghost and unassigned ghost Jul 8, 2022
@ghost ghost modified the milestones: 0.0.1, 0.0.2 Jul 8, 2022
@ghost ghost removed this from the Direct Integration with MM milestone Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

0 participants