[MM-58136] Support advanced mapping for ice host port override #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
streamer45
added
2: Dev Review
streamer45
commented
May 7, 2024
streamer45
added
3: Reviews Complete
|
Tested this on a two rtcd nodes deployment with a shared NLB in front. Looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PR adds support for a more advanced syntax in the
rtc.ice_host_port_overrideconfig setting which takes the following form:localIPA/externalPortA,localIPB/externalPortBThis becomes useful in deployments that are exposing a single public IP address and hence must be using different port numbers to map against multiple rtcd services listening internally.
The reason to pass a full mapping is to make it possible to deploy in Kubernetes where the config passed must be the same across all the pods in the deployment. Each rtcd instance will only use the port override that maps to its local IP.
/cc @coltoneshaw
Ticket Link
https://mattermost.atlassian.net/browse/MM-58136