Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make the base_url agnostic to trailing slashes #20

Closed
L0ric0 opened this issue Mar 27, 2020 · 1 comment
Closed

make the base_url agnostic to trailing slashes #20

L0ric0 opened this issue Mar 27, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@L0ric0
Copy link

L0ric0 commented Mar 27, 2020

at the moment if a base_url of the form https://example.com/ is given to the Client api calls to whoami will fail. This is because the path that is build looks like this https://example.com//_matrix/client/r0/account/whoami.
@tulir tulir added the enhancement New feature or request label Mar 27, 2020
@tulir
Copy link
Member

tulir commented Mar 27, 2020

Yeah, it should use yarl's URL. I didn't know about that when I made this, which is why it's currently just concatenating strings :D

@ShadowJonathan ShadowJonathan mentioned this issue Sep 11, 2020
Merged
@tulir tulir closed this as completed in cc43498 Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tulir @L0ric0