Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image edits from Telegram are not handled correctly #149

Closed
tulir opened this issue Jun 3, 2018 · 2 comments
Closed

Image edits from Telegram are not handled correctly #149

tulir opened this issue Jun 3, 2018 · 2 comments
Labels
bug: defect Something isn't working and it never has worked

Comments

@tulir
Copy link
Member

tulir commented Jun 3, 2018 •
edited
Loading

Official clients probably don't support it, but it's possible.
@tulir tulir added the bug: unclassified Something isn't working and it may or may not have worked in the past label Jun 3, 2018
@tulir tulir added this to the soon™ milestone Jun 3, 2018
@tulir tulir modified the milestones: 0.4.0, soon-ish™ Nov 5, 2018
@tulir tulir added bug: defect Something isn't working and it never has worked and removed bug: unclassified Something isn't working and it may or may not have worked in the past labels Dec 20, 2018
@tulir tulir changed the title Image edits from Telegram are ignored Image edits from Telegram are not handled correctly Jun 23, 2020
@tulir tulir mentioned this issue Jun 23, 2020
Closed
@JuniorJPDJ
Copy link

It's pretty common now to edit already sent images. Would be cool to have it fixed. Thanks for your development ;D

@tulir tulir removed this from the soon-ish™ milestone Jan 31, 2022
@tulir tulir mentioned this issue May 28, 2022
Closed
@tulir
Copy link
Member Author

tulir commented May 28, 2022 •
edited
Loading

Image edits should work now since I changed the bridge to store the image event ID instead of the caption event ID. It means edited captions won't work, but that's hopefully less problematic.

There's also a config option to send the caption as the body as per MSC2530, which makes everything work correctly, but clients don't really support it yet.

@tulir tulir closed this as completed May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug: defect Something isn't working and it never has worked
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tulir @JuniorJPDJ