Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix -> Telegram only sends first line of multiline message #309

Closed
L0ric0 opened this issue Apr 10, 2019 · 8 comments
Closed

Matrix -> Telegram only sends first line of multiline message #309

L0ric0 opened this issue Apr 10, 2019 · 8 comments
Labels
bug: regression Something isn't working, but it used to work before
Milestone

Comments

@L0ric0
Copy link

L0ric0 commented Apr 10, 2019

The Bridge does only send the first line of a multiline message from matrix to telegram and ignores the rest. Will see if I can find the logs.

@tulir
Copy link
Member

tulir commented Apr 11, 2019

Works fine for me with and without the relaybot and with and without formatting in the matrix message.

Make sure you're on the latest version. If it still happens, probably need some logs and preferably a reproducible test case.

@tulir tulir added the can't reproduce This bug could not be confirmed label Apr 11, 2019
@olmari
Copy link
Contributor

olmari commented Apr 11, 2019

I have this happened too, Unfortunately no logs from that time but 3 screenshots from Riot(-android), Irssi and Telegram. Riot was also sending one, markdown enabled. I sent an youtube link with smiley "xD" on first line and then actual link in next line. I am not sure did I have single linefeed or 2 of them in between.

Riot showed it as normal multiline message:
riot

Irssi showed it as 2 separate messages:
irssi

While Telegram showed only the first line of the mesage:
telegram

From these Telegram is only one that fails, whatever the reason or rootcause is.

All clients then showed the next message which was ircbot-generated URL-title.

Homeserver Synapse is version 0.99.3, Mautrix-telegram 0.5.1, Riot-android latest play-store offers and so on, everything should be up to date.

@tulir
Copy link
Member

tulir commented Apr 11, 2019

Can't reproduce that either :/

@olmari
Copy link
Contributor

olmari commented Apr 11, 2019

I am also logged in with matrix-login should that have some odd things that would change behaviour(?)

@mtippmann
Copy link

can confirm that behavoir with 0.5.1 - I've seen it also happen for users that are not logged into telegram with their matrix-login.

The respective messages had newlines between first and later lines, also bullet-points in later lines. Maybe it's useful - no logs unfortunatly.

@tulir tulir added bug: regression Something isn't working, but it used to work before and removed can't reproduce This bug could not be confirmed labels Apr 18, 2019
@tulir tulir modified the milestones: soon-ish™, 0.6.0 Apr 18, 2019
@tulir
Copy link
Member

tulir commented Apr 18, 2019

Looks like the problem is that Python's HTMLParser doesn't follow the HTML spec and handle tags like <br> as self-closing even when they're not self-closing. Probably need to override handle_startendtag and then add a check in handle_starttag to handle void elements

@Ryonez
Copy link

Ryonez commented May 10, 2019

Just popping in as the missies and I just noticed this the last few days.
So defiantly an issue still.

@tulir tulir closed this as completed in 430f7b7 May 11, 2019
@Ryonez
Copy link

Ryonez commented May 12, 2019

Thank you tulir, looks good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: regression Something isn't working, but it used to work before
Development

No branches or pull requests

5 participants