Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New room, M>T comes from bot, when should from puppet #367

Closed
olmari opened this issue Sep 29, 2019 · 3 comments · Fixed by #902
Closed

New room, M>T comes from bot, when should from puppet #367

olmari opened this issue Sep 29, 2019 · 3 comments · Fixed by #902
Labels
bug: unclassified Something isn't working and it may or may not have worked in the past

Comments

@olmari
Copy link
Contributor

olmari commented Sep 29, 2019

Issue:

Newly bridged groupchat, made by double-puppetet user (matrix-login), Matrix to Telegram messages comes from relaybot instead puppeted user. No sync commands nor cache clears resolved this, but restarting of bridge did magically corrected it, so some form of "state of things" discrepancy somewhere I suspect. Nothing suspicious observed on either Synapse nor Mautrix-telegarm logs. Also saying something with real Telegram client resulted in correct behaviour (matrix-puppet saying things in room).

Flow that I happened to use, should any part of it affect somehow:

  • Made Matrix room
  • Made Telegram group
  • Invited some TG users on TG side
  • Invited bot both sides
  • Executed bridging commands
  • Upgraded room to supergroup through bot command
  • Talked and observed this behaviour

Bridge version: d5470de

@tulir tulir added the bug: unclassified Something isn't working and it may or may not have worked in the past label Nov 17, 2020
@Craeckie
Copy link

I just encountered the same issue on current master: 78fcacf

My flow was a little different:

  • Made encrypted Matrix Room
  • Added bridge bot
  • Added relay bot
  • Created TG chat by sending !tg create
  • Added another TG user
  • Sent a message in Matrix
    -> The message was forwarded by the relay bot, even though puppeting is enabled and normally works

Restarting the bridge also fixed it for this room.

@Steffo99
Copy link
Contributor

Seems like this bug resurfaced again.

When the relay bot is in a group, messages are always sent through it, even when users are puppetted.

A screenshot of the bug on Telegram

A screenshot of the chat on FluffyChat

Restarts do not fix the problem anymore, which leads me to think that the problem is somewhere in the code.

I could work on a pull request, but I need to know where this behavior is handled in the code, as I didn't find it on my own.

@maltee1
Copy link
Contributor

maltee1 commented Mar 22, 2023

Uh, for me, restarts or a simple !tg sync does still fix the issue.

@tulir tulir closed this as completed in #902 May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: unclassified Something isn't working and it may or may not have worked in the past
Development

Successfully merging a pull request may close this issue.

5 participants