Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnails for webm animated stickers #467

Closed
tulir opened this issue May 20, 2020 · 3 comments
Closed

Thumbnails for webm animated stickers #467

tulir opened this issue May 20, 2020 · 3 comments
Labels
enhancement New feature or improvement
Milestone

Comments

@tulir
Copy link
Member

tulir commented May 20, 2020

Currently the bridge sends the WebM file itself as the thumbnail for animated stickers, which means clients like Riot don't show anything before playing them. Either using the existing video thumbnailer or making an additional lottieconverter call to get a png thumbnail should work.

@tulir tulir added the enhancement New feature or improvement label May 20, 2020
@tulir tulir added this to the 0.9.0 milestone May 20, 2020
@androidacy-user
Copy link

It seems for animated stickers it just sends a link that leads to an invalid file atm

@tulir
Copy link
Member Author

tulir commented Sep 17, 2020

If you don't enable conversion, it sends a link to a perfectly valid gzipped JSON file.

@sot-tech
Copy link
Contributor

Hello.

I think, that for webm there is no need to call lottieconverter twice: if I'm not mistaken, ffmpeg constructs webm from png series (pngs mode), which located in tmp dir, so before calling ffmpeg any of generated png could be used as thumb.

@tulir tulir closed this as completed in 522e33b Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or improvement
Development

No branches or pull requests

3 participants