Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't log private information by default #63

Closed
Tracked by #19
tulir opened this issue May 15, 2019 · 7 comments
Closed
Tracked by #19

Don't log private information by default #63

tulir opened this issue May 15, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@tulir
Copy link
Member

tulir commented May 15, 2019

Logs currently contain message content and other private information. The logs should be minimized to contain as little private information as possible without reducing usefulness when debugging.

@evilham
Copy link

evilham commented Nov 28, 2019

Related question but unsure if it should be a different Issue: It looks to me like setting:

logging:
  print_level: error

does not actually affect the logging level and from my basic Go understanding I didn't find a place where this setting is used or the config is passed to maulogger.

Am I looking wrong at things? If not, is that part of this issue?

@toxyl
Copy link

toxyl commented Jan 25, 2021

I'm seeing the same behavior and judging by this issue it has been like this for 2 years? Why is this not fixed? It should not be possible for an admin to just have plaintext logging of his/her users' messages. And even if possible, it should really not be the default setting.

@tulir
Copy link
Member Author

tulir commented Jan 25, 2021

This issue was fixed over a year ago

@tulir tulir closed this as completed Jan 25, 2021
@toxyl
Copy link

toxyl commented Jan 25, 2021

Well, I've installed this last December from the repo's master branch.

@toxyl
Copy link

toxyl commented Jan 25, 2021

And debug logging is still the default setting, see https://github.com/tulir/mautrix-whatsapp/blob/master/example-config.yaml#L258

@tulir
Copy link
Member Author

tulir commented Jan 25, 2021

The issue was primarily about message content, which is not logged even on the debug level. I might add a trace level below debug in the future that does log message content, but haven't got around to it yet.

@toxyl
Copy link

toxyl commented Jan 25, 2021

It certainly is being logged, I saw it today. That's why I responded to the issue. I was able to read messages from ANY user on my server using the WhatsApp bridge. They are logged to the log files of the bridge (I had to throw all of them away),and they show up in the syslog and can be seen when following the journal (journalctl -u your-service -f). I'm referring to the m.text field.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants