Package and tests are broken since release of Werkzeug 1.0.0

[jugmac00]

Werkzeug has moved some long deprecated functions/Classes to separate modules.

Since the release of Werkzeug 1.0.0 this package here is broken, also the tests do not work any more.

I created #28 to fix the broken imports.

Could you please cut a new release after merging the PR?

Thanks a lot!

P.S.: If you activate Travis for this repository, I'd volunteer to create a config file and do some minor housekeeping.

[andresgarita-dev]

Same problem in from werkzeug import secure_filename, FileStorage
should be from werkzeug.utils

[jugmac00]

@maxcountryman @rduplain
Thank you for accepting the pull request. Could you please cut a new release?
While it is possible to directly install from GitHub, it is quite cumbersome to configure setup.py with dependency_links.
Thank you very much!

[jugmac00]

It is not only cumbersome, it seems no longer possible:
pypa/setuptools#987 (comment)

[jugmac00]

As a workaround you can use something like
"Flask-Uploads @ https://github.com/maxcountryman/flask-uploads/archive/f66d7dc93e684fa0a3a4350a38e41ae00483a796.zip#egg=Flask-Uploads-0.2.2.dev", # noqa: E501
in your setup.py.

Attention
This fails on Travis for Python 3.6.

[Frost199]

I had to downgrade to werkzeug==0.16.0 to get it working with Flask-Uploads, everything just breaks as of the release of werkzeug==1.0.0 😢 , most things have been moved to different packages within werkzeug. It would be nice if Flask-Upload can update its library.

[maxcountryman]

Pull requests are welcome.

[Curiouspaul1]

I thought is was the only one seeing this.: cannot import name 'secure_filename' from 'werkzeug' (/opt/hostedtoolcache/Python/3.7.6/x64/lib/python3.7/site-packages/werkzeug/init.py) #98
pheww.. thought i'd screwed things up for a minute..may i ask though (WHAT's the way forward)

[jugmac00]

@maxcountryman #28 was the PR - which you already merged. But it would be very good to have a new release out there.

While you technically can pip install from a GitHub URL, it is a major pain to have a GitHub URL in a setup.py supporting different Python versions (dependency_links vs install_requires).

[maxcountryman]

Why is using a link a major pain? I’ve done this for many projects and it’s never been much of a hassle.

[jugmac00]

At least I could not find a way to run the tests of my applications successfully on Py36-Py38 with a GitHub URL in my setup.py (on Travis only - locally it worked out):

Direct url requirement (like Flask-Uploads@ https://github.com/maxcountryman/flask-uploads/archive/f66d7dc93e684fa0a3a4350a38e41ae00483a796.zip#egg=Flask-Uploads-0.2.2.dev) are not allowed for dependencies

And I tried for a bit :-)

What is the issue with cutting a release? Should not take more than a couple of minutes and would make the life of your users much easier.

I finally dropped Py3.6 - and so I am personally fine. So I am not asking for myself.

Is there anything I could do to support you?

[shaharyi]

I also upgraded to flask 1.1.1 with Werkzeug 1.0 and got the deprecate imports.
(I wanted to use Python3.7 dataclasses module for json serialization)
I'd be grateful for a release soon if possible, please.

[sgreene570]

Why is using a link a major pain? I’ve done this for many projects and it’s never been much of a hassle.

I see your point, but honestly it's just inconvenient. Also, even if a url replacement is a quick fix, that's still manual intervention that folks would have to figure out when their builds break. I am very much in favor of a new release to fix the issue and would also be willing to help with any testing or logistics for that 😄 🚀

[jgerry2002]

What exactly is holding up a new release? Latest 0.2.1 still has legacy werkzeug issue. This seems like a trivial fix vs forcing folks to patch an otherwise excellent library.

[colidyre]

I had to downgrade to werkzeug==0.16.0 to get it working with Flask-Uploads, everything just breaks as of the release of werkzeug==1.0.0 cry , most things have been moved to different packages within werkzeug. It would be nice if Flask-Upload can update its library.

Why not using the newer werkzeug==0.16.1? It is the last version before 1.0.0. This works for me.

[Gresliebear]

can someone fix this issue already?

[Pythonian]

can someone fix this issue already?

This issue was reported since Feb 6, unfortunately, 2 months after, no fix has been applied.

My app is broken.

Please what's holding the maintainers back from fixing this issue? Or are they no longer making use of this extension?

[xxxpsyduck]

You guys are so F**king lazy! just a simple command:
pip install git+https://github.com/maxcountryman/flask-uploads.git

[Frost199]

You guys are so F**king lazy! just a simple command:
pip install git+https://github.com/maxcountryman/flask-uploads.git

First, a pull request was sent and he merged the PR which is why your pip install from a git repo would work and not break, @maxcountryman is maintaining the library, you should not go about saying people are lazy if they want the merged PR to be updated with a new release.

And being an asshole while letting people know how to pip install from a GitHub repo doesn't make you superman or know it all, I wonder how you collaborate with teams, and @maxcountryman should have closed this issue a long time, you won't come here hiding behind your keyboard and calling people F@@ing Lazy.

Next time learn how to be civil about what's not yours and enlighten people properly.

[sgreene570]

You guys are so F**king lazy! just a simple command:
pip install git+https://github.com/maxcountryman/flask-uploads.git

Cutting a new release is a few clicks, no?

[maxcountryman]

This isn’t the right forum for this. Everyone, please be civil—also I’d ask that you all remember that open source work is not necessarily paid work: myself and the other maintainers are donating our time without direct monetary compensation. Regardless of how much effort it is or isn’t it’s incredibly rude to demand anyone to do anything on your behalf.