Rubyzip 1.0 compatibility

[simonoff]

No description provided.

[coveralls]

Coverage remained the same when pulling 9583b70 on simonoff:master into fe61741 on maxdemarzi:master.

[pboling]

This should be done, and it should be done in a minor version bump, due to the nature of the changes.

If projects are using rubyzip elsewhere, or have any other gems that also depend on the old rubyzip API, and those are not being updated then bumping the dependency here in a patch bump will break those projects.

👍 to bumping rubyzip version IFF it is done in at least a minor version bump of neography

Looking at the gems that have rubyzip as a dependency and it does appear that upgrading to 1.0.0 in a patch would cause a lot of problems for a lot of people. 7 have >= 0 as the version contstraint, including the compass, gherkin, and heroku gems.

🎱 Hat tip to Gemnasium: actually really useful...

[simonoff]

But compass, gherkin and heroku using rubyzip only for releasing purposes. In any case it's a good idea to support latest versions. It's like new rails release if this example will be more clear for you.

[pboling]

Absolutely, I'm only suggesting that this be included in the next minor version bump of neography (which should be done ASAP).

[maxdemarzi]

Thanks.

[petervandenabeele]

FYI, it works :-)

Bundle update (in dbd_onto) pulled in Neography 1.2.0 and rubyzip 1.0.0 and tests pass.