Improve 'windows' OS detection of taskbar location #307
Conversation
Should be helpful for the following issues max-mapper#264 max-mapper#232
Referring to the issue max-mapper#232
There was a problem hiding this comment.
this looks sensible to me, though I'd like to test this before merging.
@adam-lynch would you be able to give a test?
@semenov-oleg could you fix the linting errors? (Running yarn lint --fix from the root folder should do)
|
Sure, updated PR |
Trying to solve issue: max-mapper#298
|
fix ur program. #309 |
|
Is this going to be merged into an official release? |
|
@amaurymartiny we have users reporting this bug when the taskbar is on the left as well. Any chance we could get this merged and released? I'm happy to help test as well if needed. |
|
I unfortunately didn't get the chance to test on Windows. It seems that it's blocking a couple of users, so I am going to merge it. Thanks @semenov-oleg for the work! |
|
@amaurymartiny it seems that left sided taskbars are still broken with this PR, according to some users. |
|
#343 fixes the left-sided taskbar issue. |
Should be helpful for the following issues
#264
#232