feat: add option activateWithApp to allow not activate with this event #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amaury1093
reviewed
Oct 27, 2021
| } | ||
| }); | ||
| if (this._options.activateWithApp) { | ||
| this.app.on('activate', (_event, hasVisibleWindows) => { |
There was a problem hiding this comment.
I would like to not change the existing behavior.
Could you add inside the cleanOptions functions some logic to default this to true? E.g. if (options.activateWithApp === undefined) { options.activateWithApp = true }
| @@ -8,6 +8,10 @@ import { | |||
| * Options for creating a menubar application | |||
| */ | |||
| export interface Options { | |||
| /** | |||
| * Listen on `app.on('activate')` to open menubar when app is activated. | |||
There was a problem hiding this comment.
Suggested change
| * Listen on `app.on('activate')` to open menubar when app is activated. | |
| * Listen on `app.on('activate')` to open menubar when app is activated. | |
| * @default `true` |
|
Updated as you suggested, thanks for the quick response, looks like I can use a new version today :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #360