Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Copy index from anaconda #12

Merged
merged 21 commits into from
Dec 7, 2016
Merged

ENH: Copy index from anaconda #12

merged 21 commits into from
Dec 7, 2016

Conversation

ericdill
Copy link
Contributor

@ericdill ericdill commented Dec 6, 2016

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 6, 2016

Current coverage is 91.12% (diff: 92.79%)

Merging #12 into master will increase coverage by 3.38%

@@             master        #12   diff @@
==========================================
  Files             2          2          
  Lines           155        169    +14   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            136        154    +18   
+ Misses           19         15     -4   
  Partials          0          0          

Powered by Codecov. Last update 591fd3f...2718c3b

@ericdill
Copy link
Contributor Author

ericdill commented Dec 6, 2016

@mariusvniekerk code review please

@ericdill ericdill changed the title WIP: Copy index from anaconda ENH: Copy index from anaconda Dec 6, 2016
@ericdill
Copy link
Contributor Author

ericdill commented Dec 6, 2016

@Rapportus code review please

@@ -0,0 +1,7 @@
blacklist:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments about how these fields work would help would-be users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the wildcard syntax.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the updates to README

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do those changes satisfy that request?

args = ['-v']
# show the message output for skipped and expected failure tests
args.append('-rxs')
print('sys.argv={}'.format(sys.argv))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left over print?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps. I still find it useful to see such things, so I'd prefer to just leave it


def test_match(repodata):
repodata_info, repodata_packages = repodata.anaconda
matched = conda_mirror.match(repodata_packages, {'name': 'jupyter'})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A wildcard test case somewhere would be good too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@parente
Copy link
Contributor

parente commented Dec 7, 2016

Nothing else major to contribute on this.

Copy link

@Rapportus Rapportus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@ericdill
Copy link
Contributor Author

ericdill commented Dec 7, 2016

Thanks @Rapportus @parente

@ericdill ericdill merged commit a6e20fd into adtech-labs:master Dec 7, 2016
@ericdill ericdill deleted the copy-index-from-anaconda branch December 7, 2016 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants