-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Copy index from anaconda #12
ENH: Copy index from anaconda #12
Conversation
Current coverage is 91.12% (diff: 92.79%)@@ master #12 diff @@
==========================================
Files 2 2
Lines 155 169 +14
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 136 154 +18
+ Misses 19 15 -4
Partials 0 0
|
@mariusvniekerk code review please |
@Rapportus code review please |
@@ -0,0 +1,7 @@ | |||
blacklist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments about how these fields work would help would-be users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, the wildcard syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have a look at the updates to README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do those changes satisfy that request?
args = ['-v'] | ||
# show the message output for skipped and expected failure tests | ||
args.append('-rxs') | ||
print('sys.argv={}'.format(sys.argv)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left over print?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps. I still find it useful to see such things, so I'd prefer to just leave it
|
||
def test_match(repodata): | ||
repodata_info, repodata_packages = repodata.anaconda | ||
matched = conda_mirror.match(repodata_packages, {'name': 'jupyter'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A wildcard test case somewhere would be good too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Nothing else major to contribute on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
Thanks @Rapportus @parente |
No description provided.