Fix Type Error #30
Merged
Fix Type Error #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
==========================================
- Coverage 96.77% 94.95% -1.83%
==========================================
Files 2 2
Lines 217 218 +1
==========================================
- Hits 210 207 -3
- Misses 7 11 +4
Continue to review full report at Codecov.
|
|
code review please @marshall245 @parente |
parente
reviewed
Feb 22, 2017
| @@ -93,30 +97,11 @@ def test_cli(tmpdir, channel, platform, repodata): | |||
| assert len(rd['info']) == len(disk_info) | |||
| assert len(rd['packages']) == len(disk_packages) | |||
|
|
|||
|
|
|||
| def test_handling_bad_package(tmpdir, repodata): | |||
There was a problem hiding this comment.
Do the assertions in the test that calls this new function cover the purpose of the assertions in the removed test_handling_bad_package?
There was a problem hiding this comment.
Not entirely. Will fix that in a new commit
There was a problem hiding this comment.
Alright updated. Final check @parente ?
parente
reviewed
Feb 23, 2017
| # https://github.com/maxpoint/conda-mirror/issues/29 | ||
| _write_bad_package(channel_dir=f2.strpath, platform_name=platform, | ||
| pkg_name='bad-1-0.tar.bz2') | ||
| # Write a bad package that does exist in the upstreap repodata into the mirror path |
There was a problem hiding this comment.
Good catch. Thanks @parente
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #29