Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Rerun changelog generator #54

Merged
merged 1 commit into from
May 23, 2017
Merged

DOC: Rerun changelog generator #54

merged 1 commit into from
May 23, 2017

Conversation

ericdill
Copy link
Contributor

@ericdill ericdill commented May 23, 2017 •
edited
Loading

Amazingly good catch @jakirkham (this might sound sarcastic, but it truly is a sincere "amazingly")

jakirkham
jakirkham reviewed May 23, 2017
View reviewed changes
CHANGELOG.md
@@ -1,8 +1,7 @@
# Change Log

## [0.7.2](https://github.com/maxpoint/conda-mirror/tree/0.7.2) (2017-05-23)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still want this blank line? Not sure how you like to do formatting here. So this is merely a question.

Copy link
Contributor Author

@ericdill ericdill May 23, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still want this blank line?

The automated changelog generator removed it, so 🤷‍♂️

Not sure how you like to do formatting here.

I like to do none of the formatting and let the generator handle it 😀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it seems to do it everywhere else and looks fine there. So seems fine. 😄

@codecov
Copy link

codecov bot commented May 23, 2017

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #54   +/-   ##
=======================================
  Coverage   96.62%   96.62%           
=======================================
  Files           2        2           
  Lines         237      237           
=======================================
  Hits          229      229           
  Misses          8        8

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca89ce...30e1fa1. Read the comment docs.

@jakirkham
Copy link
Contributor

np. Glad to help. 😄

@jakirkham
Copy link
Contributor

LGTM

@ericdill ericdill merged commit a5601f0 into vericast:master May 23, 2017
@ericdill
Copy link
Contributor Author

ericdill commented May 23, 2017 •
edited
Loading

Thanks for the 👀 @jakirkham

@ericdill ericdill deleted the rerun-changelog-generator branch May 23, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericdill @jakirkham