Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: In reading mode, folding from uncollapsed to collapsed, but interrupting the fold by unfolding causes a non-smooth transition #65

Open
mayurankv opened this issue Aug 10, 2023 · 2 comments
Assignees
Labels
bug Something isn't working future work To develop into the plugin long term Non-immediate action to be taken reading mode Relevant to Obsidian reading mode

Comments

@mayurankv
Copy link
Owner

Describe the bug

In reading mode, folding from uncollapsed to collapsed, but interrupting the fold by unfolding causes a non-smooth transition

Steps to reproduce

Press on the header when uncollapsed and before fully collapsed, click it again - the unfold will be instant, not transitioned.

```lang
line 1
line 2
line 3
line 4
line 5
line 6
line 7
line 8
```

Expected behaviour

Fold should be smooth.

Current behaviour

Fold is not smooth

Environment

  • Plugin Version: 1.0.4
  • Obsidian Version: 1.3.7
  • Platform: Desktop
  • OS: macOS

Screenshots

Additional context

@mayurankv mayurankv added the bug Something isn't working label Aug 10, 2023
@mayurankv mayurankv self-assigned this Aug 10, 2023
@mayurankv mayurankv added future work To develop into the plugin reading mode Relevant to Obsidian reading mode labels Aug 10, 2023
@mayurankv
Copy link
Owner Author

Could be fixed by using a setTimeout for removing max-height at the end of transitions that can be reset (instead of await sleep()). However, one instance of this timer needs to be globally accessible to the eventHandler function.

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity.

@github-actions github-actions bot added the Stale label Oct 10, 2023
@mayurankv mayurankv removed the Stale label Oct 24, 2023
@mayurankv mayurankv added the long term Non-immediate action to be taken label Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working future work To develop into the plugin long term Non-immediate action to be taken reading mode Relevant to Obsidian reading mode
Projects
None yet
Development

No branches or pull requests

1 participant