Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Travis Build #41

Open
atz opened this issue Apr 2, 2018 · 1 comment
Open

Fix Travis Build #41

atz opened this issue Apr 2, 2018 · 1 comment

Comments

@atz
Copy link

atz commented Apr 2, 2018

Dependencies aren't compatible anymore on half of the build environments, e.g.:

NoMethodError: undefined method `last_comment' for #<Rake::Application:0x00000001216348>
/home/travis/.rvm/gems/ruby-2.3.0/gems/rspec-core-2.99.2/lib/rspec/core/rake_task.rb:143:in `initialize'
/home/travis/build/mbklein/equivalent-xml/Rakefile:17:in `new'
/home/travis/build/mbklein/equivalent-xml/Rakefile:17:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.3.0/gems/rake-12.3.0/exe/rake:27:in `<top (required)>'
/home/travis/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `eval'
/home/travis/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `<main>'
(See full trace by running task with --trace)

https://travis-ci.org/mbklein/equivalent-xml/jobs/350014687#L1128

We need to specify a new enough version of rspec (safest option), or cap at a sufficiently old version of rake. StackOverflow explains, as usual.

Recommend updating rspec.

@atz
Copy link
Author

atz commented Apr 2, 2018

For context, rspec v2.99 is from 2013, and its entire purpose was to provide all the deprecation warnings one would need to clear to get onto 3.x. I think it is safe to say we are done developing against rspec 2.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant