using "tagged_with" with .uniq or .select(distinct(...) throws DISTINCT error

[christopherdro]

Take a look under https://gist.github.com/casheghian/e1b7fd206d6434f4972b to see the search method I am using.

When using the commented out line everything works great, however I am left with duplicate results.

Using the current join and select statement or .uniq on what returns throws a
"PG::Error: ERROR: syntax error at or near "DISTINCT"
LINE 1: SELECT distinct(restaurants.id), restaurants.*, DISTINCT res.."

[prikha]

Confirm this!

[developer88]

I can confirm that - it happens when you add { any: true } option. I do believe this is because of the string in core.rb:

select_clause = "DISTINCT #{table_name}.*" unless context and tag_types.one?

and if you make a complex request all this select query added to other part of your request as is.

Tested it in 3.0.1 and 2.4.2

My solution: #461

[leklund]

The merged commit seems to call .uniq for any tagged_with query. I discovered this because I have json columns on many of my tables. If a table has a json column, using a distinct or a uniq will raise an error:

PG::UndefinedFunction: ERROR:  could not identify an equality operator for type json

Using this commit, every call to Model.tagged_with will raise this error. Before it would only raise the error when using any:true as it would include the distinct in the select.

[seuros]

Any tests to reproduce the bug ?
I'm closing this issue since that a new bug

[leklund]

Here is a test to reproduce. I'll see about creating a new bug.

  it "shouldn't generate a query with DISTINCT by default" do
    @taggable.skill_list = "ruby, rails, css"
    @taggable.save

    TaggableModel.tagged_with('ruby').to_sql.should_not match /DISTINCT/
  end