Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 5.1.0.beta1 Passing a class to the class_name is deprecated #807

Closed
Farson opened this issue Feb 27, 2017 · 3 comments
Closed

Rails 5.1.0.beta1 Passing a class to the class_name is deprecated #807

Farson opened this issue Feb 27, 2017 · 3 comments

Comments

@Farson
Copy link

Farson commented Feb 27, 2017

DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `has_many :tag_taggings, class_name: 'ActsAsTaggableOn::Tagging'`
DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `has_many :tags, class_name: 'ActsAsTaggableOn::Tag'`

rails (5.1.0.beta1)
acts-as-taggable-on (4.0.0)

@mnrk
Copy link
Contributor

mnrk commented Mar 9, 2017

I created a PR: #813

@dostapn
Copy link

dostapn commented May 22, 2018

up

@glendel
Copy link

glendel commented May 31, 2018

Please go to here : Pull Request #887 to see all the ready to merge and to use solutions to work with Rails 5.2! It is fully tested and ready to go! It is just missing to merge the changes into the main project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants