Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release new version to capture Rails 5.1 Deprecation Warning patch #826

Open
joshRpowell opened this issue May 5, 2017 · 5 comments
Open

Comments

@joshRpowell
Copy link

joshRpowell commented May 5, 2017

Context

acts-as-taggable-on is a dependency in Spree

getting the following when bumping to Rails 5.1

DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `has_many :tag_taggings, class_name: 'ActsAsTaggableOn::Tagging'` (called from block in <module:ActsAsTaggable> at /spree/core/app/models/concerns/spree/acts_as_taggable.rb:6)
DEPRECATION WARNING: Passing a class to the `class_name` is deprecated and will raise an ArgumentError in Rails 5.2. It eagerloads more classes than necessary and potentially creates circular dependencies. Please pass the class name as a string: `has_many :tags, class_name: 'ActsAsTaggableOn::Tag'` (called from block in <module:ActsAsTaggable> at /spree/core/app/models/concerns/spree/acts_as_taggable.rb:6)

https://github.com/spree/spree/blob/master/core/app/models/concerns/spree/acts_as_taggable.rb

Possible Fix

A new version release should solve the problem as the fix was patched in a recent PR here #813

@seuros
Copy link
Collaborator

seuros commented May 6, 2017

@rbritom Let prepare a release .

@ZacharyWeiner
Copy link

So is there a release planned to drop this warning?

@fuzzygroup
Copy link

Any thoughts on this?

@lucasldemello
Copy link

So is there a release planned to drop this warning?

@glendel
Copy link

glendel commented May 31, 2018

Please go to here : Pull Request #887 to see all the ready to merge and to use solutions to work with Rails 5.2! It is fully tested and ready to go! It is just missing to merge the changes into the main project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants