Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table crashes when providing components prop. #568

Closed
victor-accarini opened this issue May 11, 2019 · 0 comments
Closed

Table crashes when providing components prop. #568

victor-accarini opened this issue May 11, 2019 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@victor-accarini
Copy link
Contributor

Describe the bug
Table crashes when providing components props.

To Reproduce
Steps to reproduce the behavior:

  1. Set components prop on table with just a Container: (props) => <div {...props} />
  2. Set isLoading={true} prop on table
  3. See crash

Expected behavior
Not crash...

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: Any OS
  • Browser: Any Browser
  • Version: 1.28 and up

Additional context

This occurs because the table access this.props.components.OverlayLoading which is the props provided by the user instead of props.components.OverlayLoading.

@mbrn mbrn self-assigned this May 12, 2019
@mbrn mbrn added the bug Something isn't working label May 12, 2019
@mbrn mbrn closed this as completed in d41511c May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants