Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dense padding prop does not apply to column headers #783

Closed
jakeleventhal opened this issue Jul 2, 2019 · 4 comments
Closed

Dense padding prop does not apply to column headers #783

jakeleventhal opened this issue Jul 2, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@jakeleventhal
Copy link

Describe the bug
If you use the dense option, it does not affect the header row

To Reproduce
Steps to reproduce the behavior:

  1. Create a table with dense props

Expected behavior
The header row should be dense too

Screenshots
Screen Shot 2019-07-02 at 6 46 35 PM

@jakeleventhal
Copy link
Author

@gianlucamateo

@gianlucamateo
Copy link

I see how this would be useful, but the main reason behind the option was that some things about row heights can't be changed with styling, such as the size of the iconbuttons used for tree expansion or actions.

To my knowledge, the same does not apply to the headers, and I suggest solving the issue with custom styling.

@jakeleventhal
Copy link
Author

I get where you're coming from - but I really disagree. I think the biggest use case is for just styling purposes and wanting data to be presented in a more compact/condensed way. After all, tables are mostly just showing text data.

Having the header be a different style from the rest of the table just stands out and looks out of place.

What are your thoughts?

@gianlucamateo
Copy link

I guess it makes sense. I am, however, not going to be able to invest time into adjusting this. Maybe you could look at it?

@ekaradev ekaradev added the bug Something isn't working label Aug 1, 2019
@mbrn mbrn closed this as completed in 991e544 Jan 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants