Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common internal model for issues in PR #36

Closed
mildis opened this issue Oct 8, 2019 · 1 comment
Closed

common internal model for issues in PR #36

mildis opened this issue Oct 8, 2019 · 1 comment

Comments

@mildis
Copy link

mildis commented Oct 8, 2019

Hi,

We are working on integrating Gerrit on the pr-decoration branch.
What we observed is that whatever backend is used for PR, there is a need for the same basic datas.
Of course, depending on the tool, some additional informations may be useful.

What about creating a common internal model for issues decorated in PR ?

  • a PR message : the comment set in the tool timeline, a general message about the decoration
  • file-wide issue : not specifically related to a line or range, along its severity
  • 0 or more line-issue : issues that are bound to a line in a file (or a range of lines), along there severities too
@mc1arke
Copy link
Owner

mc1arke commented Dec 20, 2019

This should now be included in #30 through the AnalysisDetails class. Let me know if you need more added.

@mc1arke mc1arke closed this as completed Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants